Fix dtype issues #493
Merged
Fix dtype issues #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=======================================
- Coverage 95% 72% -23%
=======================================
Files 132 132
Lines 4681 4676 -5
=======================================
- Hits 4462 3365 -1097
- Misses 219 1311 +1092 |
SkafteNicki
requested review from
ananyahjha93,
ethanwharris and
SeanNaren
as code owners
This was referenced Sep 2, 2021
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@ethanwharris mind have look? ^^ |
ethanwharris
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Awesome, confirmed that this fixes my issue 😃 thanks @SkafteNicki !
Borda
approved these changes
Sep 2, 2021
ananthsub
reviewed
Sep 2, 2021
|
@SkafteNicki seems some tests are running for too long with latest versions |
SkafteNicki
commented
Sep 7, 2021
SkafteNicki
commented
Sep 7, 2021
4 tasks
This was referenced Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #492
Fixes #484
Reverts some of the changes in #462.
dtypeproperty. Metrics state can have different dtypes (like any othernn.Module) so the property probably does not make sense for all metricshalf,float,doublewill now have no effect on the dtype of metric states to prevent that metrics gets auto-cast during mix-precision. Instead if the user really wants to change the dtype of all metric states they can now do it using theset_dtypemethod.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃